NotificationsYou must be signed in to change notification settings
Fork667
Star5.7k

Fix #692 [Bug]: Passing invalid parameters to gemini throws Undefined…#693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

alxlab-zone66x wants to merge3 commits intoopenai-php:main

base:main

Choose a base branch

fromalxlab-zone66x:issue-692

Open

Fix #692 [Bug]: Passing invalid parameters to gemini throws Undefined…#693

alxlab-zone66x wants to merge3 commits intoopenai-php:mainfromalxlab-zone66x:issue-692

+56 −1

Conversation

Copy link

alxlab-zone66x commentedOct 2, 2025

… array key "choices" /www/htdocs/vendor/openai-php/client/src/Responses/Chat/CreateResponse.php 54

Change-Id: Ibbf64cc554ef68844fd8338583f3fc8ec5fde413

What:

Bug Fix

Description:

Fix issue#692

Fixopenai-php#692[Bug]: Passing invalid parameters to gemini throws…

273cc37

… Undefined array key "choices" /www/htdocs/vendor/openai-php/client/src/Responses/Chat/CreateResponse.php 54Change-Id: Ibbf64cc554ef68844fd8338583f3fc8ec5fde413

iBotPeaches reviewed

Oct 2, 2025

View reviewed changes

Copy link

Collaborator

iBotPeaches left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Could you add a test to confirm this? I think the HttpTransporter tests is the area to make a formulated Gemini exception to confirm this.

Copy link

Author

alxlab-zone66x commentedOct 2, 2025

Yeah sure. That would make sense.

Merge branch 'openai-php:main' into issue-692

18d7bb3

Copy link

Author

alxlab-zone66x commentedOct 3, 2025

Hmm for theErrorException type what do you thing would be best? Google returns:

[[            'error' => [                'code' => 400,                'message' => 'Invalid JSON payload received. Unknown name "ddd": Cannot find field.',                'status' => 'INVALID_ARGUMENT',                'details' => [                    [                        '@type' => 'type.googleapis.com/google.rpc.BadRequest',                        'fieldViolations' => [                            [                                'description' => 'Invalid JSON payload received. Unknown name "ddd": Cannot find field.',                            ],                        ],                    ],                ],            ],        ]]

type.googleapis.com/google.rpc.BadRequest would be more in line with OpenAI's typeinvalid_request_error, butINVALID_ARGUMENT is more informative imho.

Copy link

Collaborator

iBotPeaches commentedOct 3, 2025

type.googleapis.com/google.rpc.BadRequest would be more in line with OpenAI's typeinvalid_request_error, butINVALID_ARGUMENT is more informative imho.

Probably the message/status of the higher object. I think you can ignore inner details stuff.

Fixopenai-php#692[Bug]: Passing invalid parameters to gemini throws…

6591d36

… Undefined array key "choices" /www/htdocs/vendor/openai-php/client/src/Responses/Chat/CreateResponse.php 54Add tests for gemini with invalid parameter.Set ErrorException type to return error status for invalid gemini parameter.Change-Id: I076016d0470eb3060d3f972702e4e3701b52207d

alxlab-zone66x force-pushed theissue-692 branch from54d60ea to6591d36Compare

October 3, 2025 22:21

iBotPeaches reviewed

Oct 9, 2025

View reviewed changes

src/Transporters/HttpTransporter.php

Comment on lines +181 to +183

		if (!isset($data[0]['error']['type']) &&isset($data[0]['error']['status'])) {
		$data[0]['error']['type'] =$data[0]['error']['status'];
		}

Copy link

Collaborator

iBotPeachesOct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This check is the only thing I'm iffy on right now. I'd rather the ErrorException class navigate the water of different error structures to normalize them. So the HTTPTransporter isn't required to formulate things perfectly for an exception class.