Fixes resource leak and error handling issue in VoiceStreamResult where tasks are cancelled but not properly awaited during cleanup, and CancelledError could mask real exceptions.

Problem

The_cleanup_tasks() method inVoiceStreamResult had two issues:

Resource leak: Only callingtask.cancel() without awaiting could lead to:
- Unhandled task exception warnings
- Potential resource leaks from abandoned tasks
- Improper cleanup of background tasks
Error masking:_check_errors() callingtask.exception() on cancelled tasks would raiseCancelledError, masking the real exception

Evidence

Similar to fixed guardrail tasks cleanup (PRFix: Properly await cancelled guardrail tasks during cleanup #1976)
Similar to fixed voice STT cleanup (PRFix: Properly await cancelled tasks in voice STT cleanup #1977)
Similar to fixed websocket cleanup (PRfix: await cancelled websocket task to prevent resource leak #1955)
Bug documented in.claude/bug-analysis/03-resource-leaks.md

Solution

Made_cleanup_tasks() async
Collect all real asyncio.Task objects that need to be awaited
Addedawait asyncio.gather() withreturn_exceptions=True to properly collect exceptions from cancelled tasks
Updated_check_errors() to checktask.cancelled() before callingtask.exception() to avoid CancelledError
Updatedstream() async generator to await_cleanup_tasks()

Testing

Linting passes
No breaking changes to public API
Follows same pattern as PRFix: Properly await cancelled guardrail tasks during cleanup #1976,Fix: Properly await cancelled tasks in voice STT cleanup #1977,fix: await cancelled websocket task to prevent resource leak #1955

Files Changed

src/agents/voice/result.py: Fix task cleanup and error checking

Fix voice result streaming task cleanup to properly await cancelled t…

a52d0c9

…asksProblem:The _cleanup_tasks() method in VoiceStreamResult was only callingtask.cancel() on pending tasks but not awaiting them. Additionally,_check_errors() could raise CancelledError when checking cancelled tasks.This could lead to:1. Unhandled task exception warnings2. Potential resource leaks from abandoned tasks3. CancelledError masking real exceptionsEvidence:- Similar to fixed guardrail tasks cleanup (PRopenai#1976)- Similar to fixed voice STT cleanup (PRopenai#1977)- Similar to fixed websocket cleanup (PRopenai#1955)- Bug documented in .claude/bug-analysis/03-resource-leaks.mdSolution:1. Made _cleanup_tasks() async2. Collect all real asyncio.Task objects that need to be awaited3. Added await asyncio.gather() with return_exceptions=True to properly   collect exceptions from cancelled tasks4. Updated _check_errors() to skip cancelled tasks using task.cancelled()   check to avoid CancelledError when calling task.exception()5. Updated stream() async generator to await _cleanup_tasks()Testing:- Linting passes- No breaking changes to public API- Follows same pattern as PRopenai#1976,openai#1977,openai#1955

CopilotAI review requested due to automatic review settings

October 22, 2025 17:00

CopilotAI reviewed

Oct 22, 2025

View reviewed changes

Copy link

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR fixes a resource leak in the VoiceStreamResult class by properly awaiting cancelled tasks during cleanup and preventing CancelledError from masking real exceptions.

Key Changes:

Made_cleanup_tasks() async to properly await cancelled tasks usingasyncio.gather() withreturn_exceptions=True
Enhanced_check_errors() to checktask.cancelled() before callingtask.exception() to avoid CancelledError
Updated thestream() method to await the now-async_cleanup_tasks()

_{Tip: Customize your code reviews with copilot-instructions.md.Create the file orlearn how to get started.}

src/agents/voice/result.py OutdatedShow resolvedHide resolved

chatgpt-codex-connectorbot reviewed

Oct 22, 2025

View reviewed changes

Copy link

chatgpt-codex-connectorbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

src/agents/voice/result.py OutdatedShow resolvedHide resolved

gn00295120 added2 commits

October 23, 2025 01:08

Remove unnecessary try-except for CancelledError in _check_errors

7e4dfca

The task.cancelled() check on line 281 already ensures that CancelledErrorwill never be raised when calling task.exception(). The try-except blockwas redundant and added unnecessary complexity.Thanks to reviewer comment for catching this.

Preserve exceptions from gather() during task cleanup

7198e3c