- Notifications
You must be signed in to change notification settings - Fork2.8k
fix: invalid model setting when passing prompt to Agent#1852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
| conversation=self._non_null_or_not_given(conversation_id), | ||
| instructions=self._non_null_or_not_given(system_instructions), | ||
| model=self.model, | ||
| model=self.modelifpromptisNoneelseNOT_GIVEN, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
can you add a comment here explaining why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
also confirming you are sure this is correct? devs are not allowed to override the model set in the prompt?
@rm-openai good point; actually it's feasible. so, when a developer explicitly pass a model, it should be allowed. the default model still needs to be ignored. |
This PR is stale because it has been open for 10 days with no activity. |
This pull request fixes the bug reported for TS SDK, which exists for Python too.