- Notifications
You must be signed in to change notification settings - Fork116
Remove id field from the register request#579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Remove id field from the register request#579
Uh oh!
There was an error while loading.Please reload this page.
Conversation
deprecate id field from the register request
HansBusch commentedJun 5, 2025
The specification currently states |
Uh oh!
There was an error while loading.Please reload this page.
doc/WebRTC.xml Outdated
| is sent over the WebSocket connection. The signaling server shall verify the validity of | ||
| the access token. Token details are outside of the scope of this specification.</para> | ||
| the access token. The access token shall encode the device or client identity but the | ||
| token's structure and the method used to encode the client or device identity into token |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Not very happy about the requirement as it is a client side requirement. Suggest to rephrase it to a note, that it may be used to convey peer identity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@bsriramprasad I agree with@HansBusch comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I followed the existing document structure where I can see at least 3 other references as below
Ref: onvif\specs\doc\WebRTC.xml
Description: Access token that authorizes thedevice or client.
Description: ...The human readable name of thedevice or client.
Description: Access token that authorizes thedevice or client.
So depending on the discussion in the WG, I can write a general statement to refer 'device or client henceforth called as peer' and replace the above references as 'peer'?
kieran242 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@bsriramprasad approved
ocampana-videotec commentedOct 27, 2025
@bsriramprasad I faced some difficulties with this PR. For some reason, ti wanted to merge development into your branch and not the opposite. I think I merge correctly into development, but this is not showing up as expected. Could you please check development, to make sure everything is there? Thank you |
bsriramprasad commentedNov 5, 2025
@ocampana-videotec The net effect of all the merges from the list of changes under this PR seems to be affected/reduced after your development branch merges, I checked the development branch too and my changes seem to miss. Lets look at this together in F2F? |
deprecate id field from the register request