Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Add block status input arg#393

Open
Kay-Zee wants to merge1 commit intomaster
base:master
Choose a base branch
Loading
fromkan/add-block-status-input-arg

Conversation

Kay-Zee
Copy link
Member

Works towards:#392

Description

One possible solution for#392

For contributor use:

  • Targeted PR againstmaster branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation
  • Re-reviewedFiles changed in the Github PR explorer
  • Added appropriate labels

@vercel
Copy link

vercelbot commentedFeb 20, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect:https://vercel.com/onflow/flow-docs/ht404sykd
✅ Preview:https://flow-docs-git-kan-add-block-status-input-arg.onflow.vercel.app

Copy link
Contributor

@janezpodhostnikjanezpodhostnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

What would be the int to state mapping here (e.g. what value represents sealed)

@turbolent
Copy link
Member

agreed with@janezpodhostnik, maybe add an enum?

@psiemens
Copy link
Contributor

Is this PR still in progress@Kay-Zee?

@Kay-Zee
Copy link
MemberAuthor

not sure if this is still the solution we'd like to go with for solving#392

Any objections here?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@turbolentturbolentturbolent approved these changes

@lolpuddlelolpuddlelolpuddle approved these changes

@janezpodhostnikjanezpodhostnikjanezpodhostnik approved these changes

@vishalchangranivishalchangraniAwaiting requested review from vishalchangrani

@psiemenspsiemensAwaiting requested review from psiemens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@Kay-Zee@turbolent@psiemens@lolpuddle@janezpodhostnik
[8]ページ先頭
©2009-2025 Movatter.jp