- Notifications
You must be signed in to change notification settings - Fork655
Conditionally use ament_cmake to register package for colcon workspaces environment#884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
to properly regester colcon packageE.g. set AMENT_CURRENT_PREFIX environment
This isn't quite working yet, as downstream packages still can't find the path for ompl's include headerfiles. Conditionally swapping between a native cmake build_type to a ament_cmake build_type is bit advanced for my CMake-foo, so suggestions welcome. |
Is it perhaps this code that needs to change for downstream packages?:https://github.com/ompl/ompl/blob/main/CMakeLists.txt#L202-L217 |
to setup ament_generate_package_environmentand let native cmake handle the include export
The recent CMake changes to support target-based properties on ompl should make this easier. |
@ruffsl Can you confirm this is still an issue for you? |
Fixes#883 by mimicking the approach from BehaviorTree.CPP to conditionally use ament_cmake.