Commitc8b8379

committed

fix(test_index): fix encoding

I really never want to touch python again, and never deal withpy2/3 unicode handling anymore.By now, it seems pretty much anything is better.Is python to be blamed for it entirely ?Probably not, but there are better alternatives.Nim ? Rust ? Ruby ?Totally

1 parenta8f7e37 commitc8b8379Copy full SHA for c8b8379

File tree

1 file changed

-2

lines changed

git/test
- test_index.py

1 file changed

-2

lines changed

`‎git/test/test_index.py`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -787,8 +787,8 @@ def test_index_bare_add(self, rw_bare_repo):`
`787`	`787`	`deftest_add_utf8P_path(self,rw_dir):`
`788`	`788`	`# NOTE: fp is not a Unicode object in python 2 (which is the source of the problem)`
`789`	`789`	`fp=os.path.join(rw_dir,'ø.txt')`
`790`		`-withopen(fp,'w')asfs:`
`791`		`-fs.write('content of ø')`
	`790`	`+withopen(fp,'wb')asfs:`
	`791`	`+fs.write(u'content of ø'.encode('utf-8'))`
`792`	`792`
`793`	`793`	`r=Repo.init(rw_dir)`
`794`	`794`	`r.index.add([fp])`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitc8b8379

File tree

1 file changed

1 file changed

`‎git/test/test_index.py`

0 commit comments