Commitb3d9b8d

Dmitry Nikulin

authored and

committed

Fix TypeError in git.execute(..., output_stream=file)

Thisfixesgitpython-developers#619 - raise GitCommandError(not TypeError) when output_stream is setin git.execute

1 parente1d2f4b commitb3d9b8dCopy full SHA for b3d9b8d

File tree

-1

lines changed

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -794,7 +794,7 @@ def _kill_process(pid):`
`794`	`794`	`else:`
`795`	`795`	`max_chunk_size=max_chunk_sizeifmax_chunk_sizeandmax_chunk_size>0elseio.DEFAULT_BUFFER_SIZE`
`796`	`796`	`stream_copy(proc.stdout,output_stream,max_chunk_size)`
`797`		`-stdout_value=output_stream`
	`797`	`+stdout_value=proc.stdout.read()`
`798`	`798`	`stderr_value=proc.stderr.read()`
`799`	`799`	`# strip trailing "\n"`
`800`	`800`	`ifstderr_value.endswith(b"\n"):`

Comments

(0)