Commit8df3dd9

committed

fix(remote): improve version check

Make version check much more readable, and fix it atthe same time. The previous implementation would assumeprogress is supported just by looking at the patch-levelfor instance.A quick check of the git sources seems to indicate the--progress flag exists in v1.7 of the git command-linealready.Fixesgitpython-developers#449

1 parent2972481 commit8df3dd9Copy full SHA for 8df3dd9

File tree

1 file changed

-2

lines changed

git
- remote.py

1 file changed

-2

lines changed

`‎git/remote.py`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -50,8 +50,8 @@ def add_progress(kwargs, git, progress):`
`50`	`50`	`given, we do not request any progress`
`51`	`51`	`:return: possibly altered kwargs"""`
`52`	`52`	`ifprogressisnotNone:`
`53`		`-v=git.version_info`
`54`		`-ifv[0]>1orv[1]>7orv[2]>0orv[3]>3:`
	`53`	`+v=git.version_info[:2]`
	`54`	`+ifv>= (1,7):`
`55`	`55`	`kwargs['progress']=True`
`56`	`56`	`# END handle --progress`
`57`	`57`	`# END handle progress`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit8df3dd9

File tree

1 file changed

1 file changed

`‎git/remote.py`

0 commit comments