Commit87aa78c

committed

refs: added constructor flag to allow refs to be instatiated from any path, including simple test

1 parentb7ae99c commit87aa78cCopy full SHA for 87aa78c

File tree

+11

-4

lines changed

+11

-4

lines changed

Lines changed: 6 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -20,15 +20,17 @@ class Reference(SymbolicReference, LazyMixin, Iterable):`
`20`	`20`	`_resolve_ref_on_create=True`
`21`	`21`	`_common_path_default="refs"`
`22`	`22`
`23`		`-def__init__(self,repo,path):`
	`23`	`+def__init__(self,repo,path,check_path=True):`
`24`	`24`	`"""Initialize this instance`
`25`	`25`	`:param repo: Our parent repository`
`26`	`26`
`27`	`27`	`:param path:`
`28`	`28`	`Path relative to the .git/ directory pointing to the ref in question, i.e.`
`29`		`-refs/heads/master"""`
`30`		`-ifnotpath.startswith(self._common_path_default+'/'):`
`31`		`-raiseValueError("Cannot instantiate %r from path %s, maybe use %s.to_full_path(name) to safely generate a valid full path from a name"% (self.__class__.__name__,path,type(self).__name__))`
	`29`	`+refs/heads/master`
	`30`	`+:param check_path: if False, you can provide any path. Otherwise the path must start with the`
	`31`	`+default path prefix of this type."""`
	`32`	`+ifcheck_pathandnotpath.startswith(self._common_path_default+'/'):`
	`33`	`+raiseValueError("Cannot instantiate %r from path %s"% (self.__class__.__name__,path))`
`32`	`34`	`super(Reference,self).__init__(repo,path)`
`33`	`35`
`34`	`36`

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -29,6 +29,11 @@ def test_from_path(self):`
`29`	`29`	`assertisinstance(instance,ref_type)`
`30`	`30`	`# END for each name`
`31`	`31`	`# END for each type`
	`32`	`+`
	`33`	`+# invalid path`
	`34`	`+self.failUnlessRaises(ValueError,TagReference,self.rorepo,"refs/invalid/tag")`
	`35`	`+# works without path check`
	`36`	`+TagReference(self.rorepo,"refs/invalid/tag",check_path=False)`
`32`	`37`
`33`	`38`	`deftest_tag_base(self):`
`34`	`39`	`tag_object_refs=list()`

Comments

(0)