Commit6eb3af2

committed

fix(repo): use GitCmdObjectDB by default

This should fix resource leaking issues once and for all.Relatedgitpython-developers#304

1 parent1d768f6 commit6eb3af2Copy full SHA for 6eb3af2

File tree

-6

lines changed

-6

lines changed

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -5,6 +5,9 @@ Changelog`
`5`	`5`	`1.0.2 - Fixes`
`6`	`6`	`=============`
`7`	`7`
	`8`	+* IMPORTANT: Changed default object database of `Repo` objects to `GitComdObjectDB`. The pure-python implementation
	`9`	`+ used previously usually fails to release its resources (i.e. file handles), which can lead to problems when working`
	`10`	`+ with large repositories.`
`8`	`11`	* CRITICAL: fixed incorrect `Commit` object serialization when authored or commit date had timezones which were not
`9`	`12`	divisable by 3600 seconds. This would happen if the timezone was something like `+0530` for instance.
`10`	`13`	* A list of all additional fixes can be found `on github<https://github.com/gitpython-developers/GitPython/issues?q=milestone%3A%22v1.0.2+-+Fixes%22+is%3Aclosed>`_

Lines changed: 2 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -35,10 +35,7 @@`
`35`	`35`	`add_progress`
`36`	`36`	`)`
`37`	`37`
`38`		`-fromgit.dbimport (`
`39`		`-GitCmdObjectDB,`
`40`		`-GitDB`
`41`		`-)`
	`38`	`+fromgit.dbimportGitCmdObjectDB`
`42`	`39`
`43`	`40`	`fromgitdb.utilimport (`
`44`	`41`	`join,`
`@@ -62,7 +59,7 @@`
`62`	`59`	`importsys`
`63`	`60`	`importre`
`64`	`61`
`65`		`-DefaultDBType=GitDB`
	`62`	`+DefaultDBType=GitCmdObjectDB`
`66`	`63`	`ifsys.version_info[:2]< (2,5):# python 2.4 compatiblity`
`67`	`64`	`DefaultDBType=GitCmdObjectDB`
`68`	`65`	`# END handle python 2.4`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -657,7 +657,7 @@ def test_rev_parse(self):`
`657`	`657`	`assertrev_parse('@{1}')!=head.commit`
`658`	`658`
`659`	`659`	`deftest_repo_odbtype(self):`
`660`		`-target_type=GitDB`
	`660`	`+target_type=GitCmdObjectDB`
`661`	`661`	`ifsys.version_info[:2]< (2,5):`
`662`	`662`	`target_type=GitCmdObjectDB`
`663`	`663`	`assertisinstance(self.rorepo.odb,target_type)`

Comments

(0)