- Notifications
You must be signed in to change notification settings - Fork333
Description
Newer versions of oclif (v4) use aws-sdk v3 which end up generating ahuge shrinkrwarp file if you have oclif as a dev dependency (and use it programatically from within ts/js code). The fingerprint of aws-sdk v3 is so large that my CI fails with too many open files (which can indeed be workaroundable) but all that for a dev dependency of a aws-sdk that I don't even use as I don't use the commands that push anything to s3.
One simple way to reproduce/check is to just runnpm i --save-dev oclif@^3.0.0
andnpm i --save-dev oclif@^4.0.0
and compare tha package-lock.json difference. Deduped it went from ~8k lines to ~50k lines.
I would like to propose that@aws-sdk/client-cloudfront
@aws-sdk/client-s3
to become optional dependencies (and that the code is refactored in a way that initialization won't fail if these are not present) so that clients can choose wether or not these are installed & generate these huge diff from previous versions.
I can also work on a PR for it if we can agree that this is something that would be valuable for oclif.
Thanks!