- Notifications
You must be signed in to change notification settings - Fork2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Ensure for-each loops with AZ::RPI::Pass::m_attachmentBindings use the correct attachment binding count#18749
Merged
jhmueller-huawei merged 1 commit intoo3de:developmentfrommprettner-huawei:pass-attachmentbinding-iteratorMar 19, 2025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…e correct attachment binding countSigned-off-by: Markus Prettner <markus.prettner@huawei.com>
6e292f1 toed52087Comparejhmueller-huawei approved these changesMar 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for fixing this properly!
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
sig/graphics-audioCategorizes an issue or PR as relevant to SIG graphics-audio.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR introduces a new
PassAttachmentBindingListclass which is used instead of the (int m_attachmentBindingsSize,AZStd::deque<PassAttachmentBinding> m_attachmentBindings)-pair to store pass attachment bindings with the same guarantees about pointer validity as before.I introduced this class since the original approach does not guard against iteration over
m_attachmentBindings, which is not allowed since it contains only valid entries in the range [0..m_attachmentBindingsSize]. In the originalPR18673 some instances of this iteration were missed, which were fixed inPR18698; and now I found some more instances where such illegal iterations are still present (eg. inRenderPass::InitializeInternal()), which lead to errors when rebuilding passes in some cases.Therefore, I introduced this class, which does not require usages of
m_attachmentBindingsin derived pass classes to be updated, which eliminates the potential for this error entirely.How was this PR tested?
The errors when rebuilding passes (from asserts in RenderPass::InitializeInternal()) no longer occur with this PR.
Run the editor with some small test scenes, test some samples in AtomSampleViewer.