Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: Cannot read property 'filter' of null on Zeit#95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
adesege wants to merge1 commit intonuxt-community:dev
base:dev
Choose a base branch
Loading
fromadesege:fix-cannot-read-property-filter-of-null-on-zeit

Conversation

@adesege
Copy link

routes is null when using @nuxtjs/now-builder on Zeit. This fix sets an empty array when the variable null.

@codecov
Copy link

codecovbot commentedDec 31, 2019•
edited
Loading

Codecov Report

Merging#95 intodev willnot change coverage.
The diff coverage is100.00%.

Impacted file tree graph

@@            Coverage Diff            @@##               dev       #95   +/-   ##=========================================  Coverage   100.00%   100.00%           =========================================  Files            7         7             Lines          261       261             Branches        57        58    +1     =========================================  Hits           261       261
Impacted FilesCoverage Δ
lib/module.js100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update1a1b277...ea35d72. Read thecomment docs.

@NicoPennec
Copy link
Member

Thanks for your patch@adesege 🙏
But It seems not fix the root cause. Why theglobalCache.staticRoutes is empty here?

cache.staticRoutes=()=>excludeRoutes(options.exclude,globalCache.staticRoutes)

I will investigate.

TheAlexLichter reacted with thumbs up emoji

@TheAlexLichterTheAlexLichter self-requested a reviewMay 27, 2020 08:50
@NicoPennecNicoPennec self-requested a reviewMay 27, 2020 09:18
@adesegeadesegeforce-pushed thefix-cannot-read-property-filter-of-null-on-zeit branch from8a43d86 toea35d72CompareJuly 1, 2020 17:44
@adesege
Copy link
Author

@NicoPennecglobalCache.staticRoutes will hold static site routes and since the package can be used for both statically and universally generated sites, line 25 returns error if it can't find the sitemap-routes.json file in the dist folder.

I have updated line 26 to default to an empty array instead.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@TheAlexLichterTheAlexLichterAwaiting requested review from TheAlexLichter

@NicoPennecNicoPennecAwaiting requested review from NicoPennec

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adesege@NicoPennec@TheAlexLichter
[8]ページ先頭
©2009-2025 Movatter.jp