Commite358c41

committed

improve error formatting

1 parent9b9c55f commite358c41Copy full SHA for e358c41

File tree

+24

-18

lines changed

+24

-18

lines changed

Lines changed: 15 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,15 @@`
	`1`	`+//@ts-ignore no declaration files`
	`2`	`+import*asclcfrom'cli-color'`
	`3`	`+import{ParserOutput}from'./parser'`
	`4`	`+`
	`5`	`+// TODO: implement better success ouput`
	`6`	`+// export const formatSuccessOutput = (tap: ParserOutput): string => {}`
	`7`	`+`
	`8`	`+exportconstformatFailOutput=(tap:ParserOutput):string=>{`
	`9`	+letoutput=`'TESTS FAILED\n`
	`10`	`+tap.failed.forEach((fail)=>{`
	`11`	+constdetails=fail.details ?`\n${fail.details}\n\n` :''
	`12`	+output+=` ✘${fail.message}\n${details}`
	`13`	`+})`
	`14`	`+returnoutput`
	`15`	`+}`

Lines changed: 7 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,7 @@ import parser from './parser'`
`4`	`4`	`import{debounce,throttle}from'./throttle'`
`5`	`5`	`importonErrorfrom'../sentry/onError'`
`6`	`6`	`import{clearOutput,displayOutput}from'./output'`
	`7`	`+import{formatFailOutput}from'./formatOutput'`
`7`	`8`
`8`	`9`	`exportinterfacePayload{`
`9`	`10`	`stepId:string`
`@@ -52,11 +53,12 @@ const createTestRunner = (config: TestRunnerConfig, callbacks: Callbacks) => {`
`52`	`53`
`53`	`54`	`consttap=parser(stdout\|\|'')`
`54`	`55`	`if(stderr){`
`55`		`-//failures also trigger stderr`
	`56`	`+//FAIL also trigger stderr`
`56`	`57`	`if(stdout&&stdout.length&&!tap.ok){`
`57`		`-constmessage=tap.message ?tap.message :''`
`58`		`-callbacks.onFail(payload,message)`
`59`		`-displayOutput(stdout)`
	`58`	`+constfirstFailMessage=tap.failed[0].message`
	`59`	`+callbacks.onFail(payload,firstFailMessage)`
	`60`	`+constoutput=formatFailOutput(tap)`
	`61`	`+displayOutput(output)`
`60`	`62`	`return`
`61`	`63`	`}else{`
`62`	`64`	`callbacks.onError(payload)`
`@@ -66,7 +68,7 @@ const createTestRunner = (config: TestRunnerConfig, callbacks: Callbacks) => {`
`66`	`68`	`}`
`67`	`69`	`}`
`68`	`70`
`69`		`-//success!`
	`71`	`+//PASS`
`70`	`72`	`if(tap.ok){`
`71`	`73`	`clearOutput()`
`72`	`74`	`callbacks.onSuccess(payload)`

Lines changed: 1 addition & 12 deletions

Original file line number	Diff line number	Diff line change
`@@ -11,22 +11,11 @@ const getOutputChannel = (name: string): vscode.OutputChannel => {`
`11`	`11`
`12`	`12`	`constoutputChannelName='CodeRoad Output'`
`13`	`13`
`14`		`-constparseOutput=(text:string):string=>{`
`15`		`-letresult=''`
`16`		`-for(constlineoftext.split(/\r?\n/)){`
`17`		`-if(line.match(/^#/)\|\|line.match(/^notok/)){`
`18`		`-result+=line+'\n'`
`19`		`-}`
`20`		`-}`
`21`		`-returnresult`
`22`		`-}`
`23`		`-`
`24`	`14`	`exportconstdisplayOutput=(text:string)=>{`
`25`	`15`	`constchannel=getOutputChannel(outputChannelName)`
`26`	`16`	`channel.clear()`
`27`	`17`	`channel.show(true)`
`28`		`-constoutput=parseOutput(text)`
`29`		`-channel.append(output)`
	`18`	`+channel.append(text)`
`30`	`19`	`}`
`31`	`20`
`32`	`21`	`exportconstclearOutput=()=>{`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-interfaceParserOutput{`
	`1`	`+exportinterfaceParserOutput{`
`2`	`2`	`ok:boolean`
`3`	`3`	`passed:Array<{message:string}>`
`4`	`4`	`failed:Array<{message:string;details?:string}>`

Comments

(0)