- Notifications
You must be signed in to change notification settings - Fork56
Change serialization of SyncFrom to NULL#465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
taco-indenbosch wants to merge1 commit intonotion-dotnet:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Change serialization of SyncFrom to NULL#465
taco-indenbosch wants to merge1 commit intonotion-dotnet:mainfromtaco-indenbosch:bugfix/synced-block-sync-from
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
I changed the serialization of the SynFrom property from Javascript'sundefined to null as required by the API. Without it new synchronizedblocks cannot be created.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
🎉 Thanks for your first pull request! The team will review it shortly. We’re excited to have you contribute!
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I changed the serialization of the SyncFrom property from Javascript's undefined to null as required by the API. Without it new synchronized blocks cannot be created.
Description
The
NullValueHandling = NullValueHandling.Includeargument to the JsonProperty attribute ensures that .NETnullvalues are serialized as Javascriptnullvalues instead ofundefined. The Notion API requires thesync_fromproperty to benullfor new synced blocks.Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
I am using the Notion.NET library to upload converted data to Notion. Since this change I have been able to create synced blocks, both new and linking to existing ones.
Checklist: