NotificationsYou must be signed in to change notification settings
Fork34.1k
Star115k

deps: add vendor depenency crate#61072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

legendecas wants to merge3 commits intonodejs:main

base:main

Choose a base branch

fromlegendecas:cargo_vendor

Open

deps: add vendor depenency crate#61072

legendecas wants to merge3 commits intonodejs:mainfromlegendecas:cargo_vendor

Conversation

Copy link

Member

legendecas commentedDec 15, 2025•
edited
Loading

deps: add vendor depenency crate

Add cargo config to support building a unified cargo static lib to include
multiple crate dependencies to be used by Node.js.

This also allows additional crate dependencies to be added, like amaro.

deps: apply cargo vendor

Applycargo vendor, snapshotting all dependencies.

This creates a vendor directory about 15M in size.

deps: remove independent temporal

Remove independent temporal_rs dependency and use the cargo vendered one.

Refs:#60897 (comment)

Copy link

Collaborator

nodejs-github-bot commentedDec 15, 2025

Review requested:

@nodejs/gyp
@nodejs/security-wg

nodejs-github-bot added dependencies

Pull requests that update a dependency file.

needs-ciPRs that need a full CI run. labels

Dec 15, 2025

legendecas marked this pull request as draft

December 15, 2025 11:11

legendecas force-pushed thecargo_vendor branch from925c0c1 tobe1151aCompare

December 15, 2025 11:17

legendecas marked this pull request as ready for review

December 15, 2025 11:18

legendecas force-pushed thecargo_vendor branch 2 times, most recently fromc06128d toe6ac930Compare

December 15, 2025 11:30

cjihrig approved these changes

Dec 15, 2025

View reviewed changes

aduh95 added author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

request-ci

Add this label to start a Jenkins CI on a PR.

dont-land-on-v20.x

PRs that should not land on the v20.x-staging branch and should not be released in v20.x.

dont-land-on-v22.x

PRs that should not land on the v22.x-staging branch and should not be released in v22.x.

dont-land-on-v24.xPRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels

Dec 15, 2025

Copy link

Member

richardlau commentedDec 15, 2025

This invalidatestools/dep_updaters/update-temporal.sh.
Ideally we should have:

an updater script.
a new entry indoc/contributing/maintaining/maintaining-dependencies.md explaining how to maintain the crates.

This comment was marked as resolved.

legendecas added3 commits

December 15, 2025 13:31

deps: add vendor depenency crate

cd2854f

Add cargo config to support building a unified cargo static lib toinclude multiple crate dependencies to be used by Node.js.This also allows additional crate dependencies to be added, like amaro.

deps: apply cargo vendor

c9113ad

deps: remove independent temporal

bd15577

Remove independent `temporal_rs` dependency and use the cargo vendoredone.

legendecas force-pushed thecargo_vendor branch frome6ac930 tobd15577Compare

December 15, 2025 13:32

Copy link

codecovbot commentedDec 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.02%. Comparing base (4f24aff) to head (bd15577).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@##             main   #61072      +/-   ##==========================================- Coverage   88.53%   88.02%   -0.52%==========================================  Files         703      703                Lines      208546   208546                Branches    40217    40137      -80     ==========================================- Hits       184634   183570    -1064- Misses      15926    16938    +1012- Partials     7986     8038      +52

see 100 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

aduh95 approved these changes

Dec 15, 2025

View reviewed changes

Copy link

Contributor

aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm not going to pretend I've reviwed all the changes in deps, but overall LGTM

Copy link

MemberAuthor

legendecas commentedDec 15, 2025•
edited
Loading

I'm not going to pretend I've reviwed all the changes in deps, but overall LGTM

The only interesting commit should be the first commit. The rest two commits should be reproduced with scripts likecargo vendor, andrm -rf deps/temporal.