Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork234
Use NOCK_ENV=replay by default#654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Replaying HTTP requests makes the tests faster and aligns them with CI.
geigerzaehler commentedApr 4, 2025
Could I get some feedback on this? |
aduh95 commentedApr 4, 2025
I'm not sure, it would feel a bit "too magical" for the default behavior to not match reality. Is it so bad to have to set the variable manually / go through the network? |
geigerzaehler commentedApr 4, 2025
I don’t see an issue with this. This is test code and people will expect mocks, etc. that don’t match reality. Right now the default behavior does not match what is run on CI, which is worse, I think. I was very confused when my tests where failing on CI but not locally. Using the recording is also faster and more reliable for for local development.
|
Replaying HTTP requests makes the tests faster and aligns them with CI.
I only realized quite late that the tests get a lot faster so I thought it would be a good idea to make that the default.