Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Use NOCK_ENV=replay by default#654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
geigerzaehler wants to merge1 commit intonodejs:main
base:main
Choose a base branch
Loading
fromgeigerzaehler:test-replay-default

Conversation

@geigerzaehler
Copy link
Contributor

Replaying HTTP requests makes the tests faster and aligns them with CI.

I only realized quite late that the tests get a lot faster so I thought it would be a good idea to make that the default.

Replaying HTTP requests makes the tests faster and aligns them with CI.
@geigerzaehler
Copy link
ContributorAuthor

Could I get some feedback on this?

@aduh95
Copy link
Contributor

I'm not sure, it would feel a bit "too magical" for the default behavior to not match reality. Is it so bad to have to set the variable manually / go through the network?

@geigerzaehler
Copy link
ContributorAuthor

I'm not sure, it would feel a bit "too magical" for the default behavior to not match reality.

I don’t see an issue with this. This is test code and people will expect mocks, etc. that don’t match reality. Right now the default behavior does not match what is run on CI, which is worse, I think. I was very confused when my tests where failing on CI but not locally. Using the recording is also faster and more reliable for for local development.

Is it so bad to have to set the variable manually / go through the network?
Of course it’s easy to set the environment variable. But this is nowhere documented for new contributors and even I sometimes forget.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@geigerzaehler@aduh95

[8]ページ先頭

©2009-2025 Movatter.jp