Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

lookup: re-add winston#983

Draft
Trott wants to merge2 commits intomain
base:main
Choose a base branch
Loading
fromre-add-winston
Draft

lookup: re-add winston#983

Trott wants to merge2 commits intomainfromre-add-winston

Conversation

Trott
Copy link
Member

Checklist
  • npm test passes
  • contribution guidelines followed
    here

@codecov-commenter
Copy link

codecov-commenter commentedSep 24, 2023•
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base(f15c9a2) 96.44% compared to head(bc73fe5) 96.44%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@##             main     #983   +/-   ##=======================================  Coverage   96.44%   96.44%           =======================================  Files          28       28             Lines        2139     2139           =======================================  Hits         2063     2063             Misses         76       76

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

@Trott
Copy link
MemberAuthor

Looks like the tests are passing now and this can land?

@targos
Copy link
Member

targos commentedAug 4, 2024•
edited
Loading

@targos
Copy link
Member

It failed on Windows.

@Trott
Copy link
MemberAuthor

It failed on Windows.

Maybe we can re-add it with skipping Windows then?

@targos
Copy link
Member

@Trott
Copy link
MemberAuthor

Sure, here's a full CI job:https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker-pipeline/258/

Looks like it's still failing. Oh well. Back to draft mode until someone wants to look into it or enough time has passed that it makes sense to try again.

@TrottTrott marked this pull request as draftAugust 7, 2024 15:33
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ljharbljharbljharb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@Trott@codecov-commenter@targos@ljharb
[8]ページ先頭
©2009-2025 Movatter.jp