Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

cli: add --audit and --auditList options#600

Open
bzoz wants to merge1 commit intonodejs:main
base:main
Choose a base branch
Loading
fromJaneaSystems:bartek-citgm-audit

Conversation

bzoz
Copy link
Contributor

In short: on Windows runningcitgm-all --auditList platform will list all modules that are flaky/skipped on win32. Runningcitgm-all --audit platform will run the smoke tests for all the skipped/flaky modules.

Addscitgm-all --auditList option which will list all modules that are flaky or skipped on current machine, including the the reason a module is skipped:

  • version
  • distro
  • release
  • platform
  • endian
  • fips

Runningcitgm-all --auditList reson1 reasn2... will show only the modules that are skipped or flaky because they match given reason.

Callingcitgm-all --audit will run the smoke tests for all modules that are skipped or flaky. Tested modules can also be filtered by providing list of "reasons" to test.

Checklist
  • npm test passes
  • tests are included
  • documentation is changed or added
  • contribution guidelines followedhere

The test for current master do not pass neither on my WSL installation nor on my Win10 box. I've added some tests, I'll add more when I gettest\bin\test-citgm-all.js work on Windows.

bnb and hebertcisco reacted with hooray emojibnb and hebertcisco reacted with heart emoji
Adds `citgm-all --auditList` option which will list all modules thatare flaky or skipped on current machine, including the the matchedreason: "version", "distro", "release", "platform", "endian" or "fips".Running `citgm-all --auditList reson1 reasn2...` will show only themodules that are skipped or flaky because they match given reason.Calling `citgm-all --audit` will run the smoke tests for all modulesthat are skipped or flaky. Tested modules can also be filtered byproviding list of "reasons" to test.
profnandaa

This comment was marked as off-topic.

@MylesBorins
Copy link
Contributor

Should we close this?

@bzoz
Copy link
ContributorAuthor

bzoz commentedApr 6, 2019

I think we should land this, but I didn't have time recently to write tests.

@BridgeARBridgeAR added the WIPWork in progress labelApr 13, 2019
@MylesBorinsMylesBorins changed the base branch frommaster tomainAugust 14, 2020 21:00
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@profnandaaprofnandaaprofnandaa left review comments

Assignees
No one assigned
Labels
WIPWork in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@bzoz@MylesBorins@profnandaa@BridgeAR

[8]ページ先頭

©2009-2025 Movatter.jp