Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork354
lib/types:maybeRaw should propagateelemType's sub-options#2341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
I have no idea howthis change could trigger that though... |
| inherit(elemType) | ||
| getSubModules | ||
| getSubOptions | ||
| substSubModules |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think a propersubstSubModules is a little more complex than just re-using the elem-type's
Is this PR still relevant? |
Forgot it existed tbh, but I think it may still be relevant for potentially allowing us to drop our patches for making It needs some cleanup or reduction in scope, as I didn't understand things like |
This istechnically redundant, because we patch
eitherto be recursive. But I think it is best ifmaybeRawdoes this explicitly, without relying on that behaviour.