Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[WIP]: new-plugin CI workflow#2255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
MattSturgeon wants to merge22 commits intonix-community:main
base:main
Choose a base branch
Loading
fromMattSturgeon:new_plugin_ci

Conversation

@MattSturgeon
Copy link
Member

Initial conceptual stub for a CI workflow that can announce new plugins.

Pushing this up WIP and unfinished as I find GitHub workflows particularly draining 😅

Hopefully I've stubbed enough out that someone could continue this if I eventually abandon it. 👀

# Default: matrix.org
server: matrix.org
# TODO: token
token: ...
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Should be able to have@GaetanLepage set up a repo environment variable for this that we can reference

Copy link
MemberAuthor

@MattSturgeonMattSturgeonSep 15, 2024
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yeah. Generating a token is documented upstreamhere. I guess we'd want a dedicated "bot" user?

Assuming the repo secret will be namedCI_MATRIX_TOKEN for now.

khaneliman reacted with thumbs up emoji
@MattSturgeon
Copy link
MemberAuthor

Barring some testing and cleanup, this should be functionally complete.

I've been testing the python script (used to generate a workflow matrix, and get some other metadata) as follows:

# Test the raw data collection:$ nix run .#ci-new-plugin-matrix -- github:nix-community/nixvim/336ba155ffcb20902b93873ad84527a833f57dc8 --head 95b322a5220744a5cac725e62fa4e612851edbc2 --raw# Test the formatted messages produced:$ nix run .#ci-new-plugin-matrix -- github:nix-community/nixvim/336ba155ffcb20902b93873ad84527a833f57dc8 --head 95b322a5220744a5cac725e62fa4e612851edbc2

Which appears to be working correctly.

I haven't gotten around to testing the CI workflow itself, but I have attempted to extract as much complexity as possible out of the workflow and into the python script.

As far as cleanup is concerned, it'd be nice to:

  • improve the CLI interface
  • comment any confusing code
  • DRY up the github rest api functions

Any early feedback and/or help testing would be greatly appreciated!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@khanelimankhanelimankhaneliman left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MattSturgeon@khaneliman

[8]ページ先頭

©2009-2025 Movatter.jp