nipy/nibabelPublic

NotificationsYou must be signed in to change notification settings
Fork269
Star746

REL: 3.2.0#960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

effigies merged 4 commits intomasterfromrel/3.2.0

Oct 20, 2020

Merged

REL: 3.2.0#960

effigies merged 4 commits intomasterfromrel/3.2.0

Oct 20, 2020

Conversation

Copy link

Member

effigies commentedOct 16, 2020•
edited
Loading

Preparation for new feature release 3.2.0, targeting Monday, October 19.

There's room for fixes to get in first, but this is pretty overdue, so I'm not inclined to hold up for anything but critical bugs.

Open PRs that could probably finish off:

NF: Adds overlay option in OrthoSlicer3D #850 (Submitter:@rmarkello)
ENH: Add option to infer CIFTI-2 intent codes #932 (Submitter:@mgxd)
NF: volume computation function for nifti masks #952 (Submitter:@JulianKlug)
FIX: Change reader to also support tck files from mrtrix3-dev tckedit #957 (Submitter:@mattcieslak)

Please comment to flag any other issues that should be addressed.

Pre-release checklist

Review the open list ofnibabel issues. Check whether there are outstanding issues that can be closed, and whether there are any issues that should delay the release. Label them!
Review and update the release notes. Review and update theChangelog file.
Look atdoc/source/index.rst and add any authors not yet acknowledged.
Use the opportunity to update the.mailmap file if there are any duplicate authors listed fromgit shortlog -nse.
Check the copyright year indoc/source/conf.py
Refresh theREADME.rst text from theLONG_DESCRIPTION ininfo.py by runningmake refresh-readme.
Check the dependencies listed insetup.cfg (e.g.,install_requires,options.extras_require) and indoc/source/installation.rst and inrequirements.txt and.travis.yml. They should at least match. Do they still hold? Make sure nibabel on travis is testing the minimum dependencies specifically.
Make sure all tests pass (from the nibabel root directory):pytest --doctest-modules nibabel

Adapted fromhttp://nipy.org/nibabel/devel/make_release.html#release-checklist

Copy link

codecovbot commentedOct 16, 2020•
edited
Loading

Codecov Report

Merging#960 intomaster willnot change coverage.
The diff coverage isn/a.

@@           Coverage Diff           @@##           master     #960   +/-   ##=======================================  Coverage   91.89%   91.89%           =======================================  Files         101      101             Lines       12548    12548             Branches     2208     2208           =======================================  Hits        11531    11531             Misses        680      680             Partials      337      337

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update022832e...0469d5a. Read thecomment docs.

effigies commented

Oct 16, 2020

View reviewed changes

.zenodo.json

		"name":"Raktivan, Konstantinos"
		},
		{
		"name":"Cal\u00e1bkov\u00e1, Mark\u00e9ta"

Copy link

MemberAuthor

effigiesOct 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@MeggyCal I've added you to the Zenodo fragment, and you will be listed as an author in theZenodo archive. Please let me know if you would like your name to be rendered otherwise, or if you have an affiliation and/orORCID you would to use. I can also remove you if you'd rather not be listed as an author.

Copy link

Contributor

MeggyCalOct 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

thanks a lot, I am honoured :) it is good as it is, thank you for messing up with unicode characters :)

effigies commented

Oct 16, 2020

View reviewed changes

.zenodo.json

		"orcid":"0000-0001-5018-7895"
		},
		{
		"name":"Gauthier, Carl"

Copy link

MemberAuthor

effigiesOct 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@krallznut I've added you to the Zenodo fragment, and you will be listed as an author in theZenodo archive. Please let me know if you would like your name to be rendered otherwise, or if you have an affiliation and/orORCID you would to use. I can also remove you if you'd rather not be listed as an author.

effigies commented

Oct 16, 2020

View reviewed changes

.zenodo.jsonShow resolvedHide resolved

JulianKlug mentioned this pull request

Oct 18, 2020

NF: volume computation function for nifti masks#952

Merged

1 task

effigies added2 commits

October 20, 2020 07:59

MNT: Update mailmap

1fa5600

DOC: Note new minimum Numpy

7da8b89

effigies force-pushed therel/3.2.0 branch from6779d1e tob251a23Compare

October 20, 2020 12:04

effigies commented

Oct 20, 2020

View reviewed changes

.zenodo.json

		"orcid":"0000-0003-4662-0558"
		},
		{
		"name":"Klug, Julian"

Copy link

MemberAuthor

effigiesOct 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@JulianKlug I've added you to the Zenodo fragment, and you will be listed as an author in theZenodo archive. Please let me know if you would like your name to be rendered otherwise, or if you have an affiliation and/orORCID you would to use. I can also remove you if you'd rather not be listed as an author.