- Notifications
You must be signed in to change notification settings - Fork269
ENH: Add get/set_zooms(units='norm') to manipulate zooms in mm/s units#567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
effigies wants to merge24 commits intonipy:masterChoose a base branch fromeffigies:enh/norm_units
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Open
Changes from1 commit
Commits
Show all changes
24 commits Select commitHold shift + click to select a range
3f3b450 ENH: Add get_norm_zooms for zooms in mm/s units
effigiesd26acfb ENH: Add get_norm_zooms for MGHHeader
effigiesde9323c ENH: Add set_norm_zooms
effigies5c30366 FIX: Various unit issues
effigies4b86d3e TEST: Test get/set_norm_zooms
effigieseb1d8ff TEST: Fix warnings
effigies6ba8b66 RF: get_norm_zooms -> get_zooms(units="canonical")
effigies1357a3b TEST: Update get_zooms tests
effigies096da88 FIX: Set default t_code even if no t_zoom
effigies798fc4e TEST: Add units specification to tests
effigiesf31aba5 TEST: Add setup/teardown to try to catch warnings properly [WIP]
effigies27234c3 TEST: Try using clear_and_catch_warnings
effigies8899bc7 RF: Add units parameter to set_zooms
effigiesda54665 TEST: More complete zoom testing, revert unnecessary change
effigies1620f31 TEST: Improve warning filters, check set_zooms behavior more thoroughly
effigies5d96f5c TEST: Explicitly test non-temporal t_units during set_zooms(units="no…
effigies233f7f0 TEST: Filter warnings for unmodified superclass tests only
effigies4babf08 ENH: Add units/raise_unknown to MINC/ECAT get_zooms
effigies6cd83f7 ENH: Validate units parameter in all get/set_zooms
effigies94cbd0d FIX: Correct and simplify NIFTI logic
effigiescfc5abe TEST: Clear nifti1 module warnings
effigies3562921 TEST: Check edge cases
effigiesd9199ca TEST: Add unit to bad set_zoom call
effigies98e43a0 TEST: Check get_zooms units arg in MINC/ECAT
effigiesFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
TEST: Add unit to bad set_zoom call
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commitd9199caa29ba759b78bfaf3764d961962f4e01c5
There are no files selected for viewing
2 changes: 1 addition & 1 deletionnibabel/tests/test_spatialimages.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.