Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

type: Track type of SpatialImage.affine, test type inference#1411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
effigies wants to merge7 commits intonipy:master
base:master
Choose a base branch
Loading
fromeffigies:type/spatialimage-affines

Conversation

@effigies
Copy link
Member

This PR lays some groundwork for further type annotations. The main thing it does is makeSpatialImage generic over its affine type, which can either beAffine (an alias for ndarray that might be refined in the future) orNone.

This is a somewhat pedantic thing to track, as it is extremely rare not to provide an affine to an image, but there are cases where it is the correct thing to do. This allows for a forthcoming PR to annotate functions that require an affine or can accept an image withNone in it.

It also introduces tests where we specifically test for whatmypy says the types of variables are, which lets us verify not only that our types are internally valid, but that they expose what we expect to downstream users.

@codecov
Copy link

codecovbot commentedFeb 16, 2025
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.35%. Comparing base(84294f4) to head(f1f6cfe).

Additional details and impacted files
@@            Coverage Diff             @@##           master    #1411      +/-   ##==========================================+ Coverage   95.34%   95.35%   +0.01%==========================================  Files         208      209       +1       Lines       29772    29783      +11       Branches     3355     3353       -2     ==========================================+ Hits        28385    28400      +15+ Misses        948      947       -1+ Partials      439      436       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@effigieseffigiesforce-pushed thetype/spatialimage-affines branch 3 times, most recently from26dbefe to67acfdcCompareFebruary 16, 2025 15:14
@effigies
Copy link
MemberAuthor

This is ready to go. Reviews welcome, or else will merge on Thursday, Feb 20.

@effigieseffigiesforce-pushed thetype/spatialimage-affines branch from67acfdc tof1f6cfeCompareMarch 14, 2025 21:42
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@jhlegarretajhlegarretajhlegarreta approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@effigies@jhlegarreta

[8]ページ先頭

©2009-2025 Movatter.jp