Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

ENH: Add minimal type annotations and run mypy in CI#1115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
effigies merged 5 commits intomasterfromenh/type_annotations
Jan 6, 2023

Conversation

@effigies
Copy link
Member

@effigieseffigies commentedJun 16, 2022•
edited
Loading

This PR aims to get us started down the path of type annotations (#1109) by getting to a minimal workingmypy check.

These annotations are not intended to be comprehensive, but resolved mypy errors in what seemed the most correct and succinct way.

Thanks to@simkarwin's#1152 I've learned that we can usefrom __future__ import annotations to use Python 3.10-style annotations in a code-base that supports Python 3.7, which is quite nice.

I've shielded thetests/ directories from type checking for now. Resolving issues there will probably help stress test our annotations, but it's a bit much for my current attention span.

fepegar and jond01 reacted with heart emoji
@codecov
Copy link

codecovbot commentedJun 16, 2022•
edited
Loading

Codecov Report

Base:92.38% // Head:92.38% // No change to project coverage 👍

Coverage data is based on head(02c7a34) compared to base(cfa209a).
Patch has no changes to coverable lines.

❗ Current head02c7a34 differs from pull request most recent head85f4cb4. Consider uploading reports for the commit85f4cb4 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@##           master    #1115   +/-   ##=======================================  Coverage   92.38%   92.38%           =======================================  Files          97       97             Lines       12250    12250             Branches     2525     2525           =======================================  Hits        11317    11317             Misses        613      613             Partials      320      320

Help us with your feedback. Take ten seconds to tell ushow you rate us. Have a feature suggestion?Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment?Let us know in this issue.

@effigies

This comment was marked as resolved.

@effigieseffigiesforce-pushed theenh/type_annotations branch 2 times, most recently from73a443b to7cbc4d3CompareJanuary 2, 2023 06:22
@effigieseffigies changed the titleENH: Add type annotationsENH: Add minimal type annotations and run mypy in CIJan 2, 2023
@effigieseffigies marked this pull request as ready for reviewJanuary 2, 2023 06:26
@effigieseffigies added this to the5.0.0 milestoneJan 2, 2023
@effigieseffigiesforce-pushed theenh/type_annotations branch 4 times, most recently frombf14770 to83aa395CompareJanuary 2, 2023 16:49
@effigies
Copy link
MemberAuthor

If anybody's feeling typish, I would appreciate a review here.

@effigieseffigiesforce-pushed theenh/type_annotations branch 4 times, most recently from73da8b0 toe5b6a66CompareJanuary 3, 2023 17:51
@effigies
Copy link
MemberAuthor

I plan to merge this in the morning. If someone wants to review first but hasn't found time, let me know.

@effigieseffigies merged commita60d2b7 intomasterJan 6, 2023
@effigieseffigies deleted the enh/type_annotations branchJanuary 6, 2023 16:11
@fepegar
Copy link
Contributor

This is great. Thanks,@effigies!

effigies reacted with thumbs up emoji

@fepegar
Copy link
Contributor

I'm still gettingSkipping analyzing "nibabel": module is installed, but missing library stubs or py.typed marker for the latest release. Do you need apy.typed file?

@fepegar
Copy link
Contributor

Happy to contribute, if you do.

@effigies
Copy link
MemberAuthor

Please do!

@effigies
Copy link
MemberAuthor

Fernando, I went ahead and opened#1196.

fepegar reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@effigies@fepegar
[8]ページ先頭
©2009-2025 Movatter.jp