- Notifications
You must be signed in to change notification settings - Fork269
ENH: Add MZ3 format#1066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
ENH: Add MZ3 format#1066
Uh oh!
There was an error while loading.Please reload this page.
Conversation
pep8speaks commentedNov 19, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Hello@effigies, Thank you for updating!
To test for issues locally, Comment last updated at 2021-11-19 13:45:48 UTC |
codecovbot commentedNov 19, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## master #1066 +/- ##==========================================- Coverage 95.34% 94.91% -0.43%========================================== Files 209 210 +1 Lines 29777 29917 +140 Branches 3357 3380 +23 ==========================================+ Hits 28390 28396 +6- Misses 948 1073 +125- Partials 439 448 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
neurolabusc commentedJan 16, 2022
@effigies thanks for supporting this. Themz3 specification is here.
Happy to work directly with you to tidy this up. |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Currently implements reading the header and "scalar" array. Haven't tested if we need to switch ordering to handle multiple scalar arrays. Does not yet implement reading vertices, faces or rgba.
Two significant wrinkles to this format:
member-size mod 2**32field in the gzip footer to detect the size. If we hit 20GB we bet that it's a weird file and just seek to the end of the gzip stream.Loading face/header data will be a good test for BIAP 0009 (#1056), but don't want to clog up that PR at the moment.