generated fromnginx/template-repository
- Notifications
You must be signed in to change notification settings - Fork125
feat: add nginx.org/app-root annotation to NIC#1578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
AlexFenlon wants to merge1 commit intonic-release-5.4Choose a base branch
base:nic-release-5.4
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+2 −0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
✅ Deploy Preview will be available once build job completes!
|
ADubhlaoich approved these changesDec 15, 2025
6 tasks
vepatel approved these changesDec 19, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
documentationImprovements or additions to documentation product/nicIssues related to NGINX Ingress Controller
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adds nginx.org/app-root to NIC, same functionality as ingress-nginx
implementation pr:nginx/kubernetes-ingress#8720
Checklist
Before sharing this pull request, I completed the following checklist:
Footnotes
Potentially sensitive information includes personally identify information (PII), authentication credentials, and live URLs. Refer to thestyle guide for guidance about placeholder content.↩