- Notifications
You must be signed in to change notification settings - Fork125
Add more information to agent v3 upgrade page.#1566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview will be available once build job completes!
|
Uh oh!
There was an error while loading.Please reload this page.
| When upgrading to NGINX Agent v3, the installer automatically backs up all configuration files before proceeding. It also converts your v2 configuration to the v3 format, ensuring compatibility and preserving settings. | ||
| {{< call-out "note" >}} | ||
| If you are using a version**older than NGINX Agent v2.31.0**, you must stop NGINX Agent before updating: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You may want to include the syntax to get the version. I know you have it in a later step, but having it earlier would help the user settle any doubts about the version they have installed.
| 1. Open an SSH connection to the server where you've installed NGINX Agent. | ||
| 1. Make a backup copy of the following locations to ensure that you can successfully recover if the upgrade does not complete |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The document earlier explains that the upgrade process makes a backup of your config files for you. Yet, step one has the use make backup files themselves. Why both?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The installer will only back up the nginx-agent.conf file not the /nginx-agent directory.
| - [Full list of v3 environment variables]({{< ref"/nginx-one-console/agent/configure-instances/configuration-overview/">}}) | ||
| Taking an example docker-compose file running a NGINX Agent v2 and update to v3. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It might be better to show the v2 ENV vars right beside the updated v3 names for them in a table, rather than showing multiple examples files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It might be a good idea to show an example on what each variable value should look like/its format etc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Good point. Including whether or not to use quotes.
Co-authored-by: Daniel Edgar <d.edgar@f5.com>
Proposed changes
Checklist
Before sharing this pull request, I completed the following checklist:
Footnotes
Potentially sensitive information includes personally identify information (PII), authentication credentials, and live URLs. Refer to thestyle guide for guidance about placeholder content.↩