Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add nap5 prerequisites#1370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
zahava-brown wants to merge3 commits intonginx:main
base:main
Choose a base branch
Loading
fromzahava-brown:nap5-prerequisites

Conversation

@zahava-brown
Copy link
Contributor

Proposed changes

Checklist

Before sharing this pull request, I completed the following checklist:

Footnotes

  1. Potentially sensitive information includes personally identify information (PII), authentication credentials, and live URLs. Refer to thestyle guide for guidance about placeholder content.↩

@zahava-brownzahava-brown requested a review froma team as acode ownerOctober 26, 2025 12:20
@github-actionsgithub-actionsbot added documentationImprovements or additions to documentation product/wafIssues related to F5 WAF for NGINX labelsOct 26, 2025
@zahava-brownzahava-brown changed the titleAdd nap5 prerequisitesDRAFT: Add nap5 prerequisitesOct 26, 2025
@zahava-brownzahava-brown marked this pull request as draftOctober 27, 2025 11:23
@zahava-brownzahava-brown changed the titleDRAFT: Add nap5 prerequisitesAdd nap5 prerequisitesOct 27, 2025
Copy link
Member

@ADubhlaoichADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

There is absolutely no context around what this new document has been created for, or what problem it is attempting to solve.

Every single deployment document already has a "Before you begin" section which includes all of this detail, and any logical links between this page and others are at the very bottom.

image

This entire page is redundant with the detail on the existing pages, meaning that a user will read through all possible requirements for any possible deployment even if they are only interested in one, only to come across the exact same set of requirements for their desired deployment at the top of the actual deployment page.

This is a pattern that does not exist in any product documentation for the rest of the NGINX portfolio.

@zahava-brown
Copy link
ContributorAuthor

zahava-brown commentedNov 9, 2025•
edited by ADubhlaoich
Loading

There is absolutely no context around what this new document has been created for, or what problem it is attempting to solve.

Every single deployment document already has a "Before you begin" section which includes all of this detail, and any logical links between this page and others are at the very bottom.

imageThis entire page is redundant with the detail on the existing pages, meaning that a user will read through all possible requirements for any possible deployment even if they are only interested in one, only to come across the exact same set of requirements for their desired deployment at the top of the actual deployment page.

This is a pattern that does not exist in any product documentation for the rest of the NGINX portfolio.

The changes are part of an internal ticket to improve nap5 prerequisite documentation. Right now it is all 1 page and with the help of@ADubhlaoich will be integrated into existing pages

@mjang
Copy link
Contributor

In our F5 WAF for NGINX docs, we currently have "Before you begin" sections. Example:

Is there still a need for this PR,@zahava-brown ?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@mouraddmeirimouraddmeirimouraddmeiri left review comments

@ADubhlaoichADubhlaoichADubhlaoich requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

documentationImprovements or additions to documentationneeds informationproduct/wafIssues related to F5 WAF for NGINX

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zahava-brown@mjang@ADubhlaoich@mouraddmeiri
[8]ページ先頭
©2009-2025 Movatter.jp