- Notifications
You must be signed in to change notification settings - Fork4
fix: don't wrap first part of command in quotes#54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
It seems as though some Windows systems don't allow the first part ofthe command to be wrapped in quotes. We couldn't detect this issue onCI, but this was reported by a user.Fixes#7
codecov-commenter commentedOct 17, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #54 +/- ##========================================= Coverage 100.00% 100.00% ========================================= Files 2 2 Lines 27 32 +5 =========================================+ Hits 27 32 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This swaps the internal implementation to use the new shell.cmd() API.This avoids the need for wrapping with double quotes which should alsomean better compatibility on Windows.
It seems as though some Windows systems don't allow the first part of the command to be wrapped in quotes. We couldn't detect this issue on CI, but this was reported by a user.
Fixes#7