Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.1k
Fixes flaky E2E test in sample 26-queues that occasionally fails withECONNRESET error.#16091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
som14062005 wants to merge2 commits intonestjs:masterChoose a base branch fromsom14062005:fix/sample-26-queues-flaky-test
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Fixes flaky E2E test in sample 26-queues that occasionally fails withECONNRESET error.#16091
som14062005 wants to merge2 commits intonestjs:masterfromsom14062005:fix/sample-26-queues-flaky-test
+1 −1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
coveralls commentedDec 17, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Pull Request Test Coverage Report forBuild ffc54c37-ca48-4eb9-bab1-c9d369f406c1Details
💛 -Coveralls |
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The test
should handle multiple concurrent requestswas sending 5 concurrent requests, which sometimes caused Redis connection exhaustion in CI, leading to intermittent failures.Solution
Reduced concurrent requests from 5 to 3 to prevent connection exhaustion while still testing concurrent request handling.
Changes
Testing
Ran E2E tests multiple times locally and in CI to verify stability.
Fixes flaky test from#16070
cc@kamilmysliwiec