Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore(common): Backport FileTypeValidator fallback support to v10.4.17#15003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
mag123c wants to merge1 commit intonestjs:10.4.17
base:10.4.17
Choose a base branch
Loading
frommag123c:backport/10.4.17-filetype-fallback

Conversation

@mag123c
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

File validation fails when the buffer is too small or unidentifiable by magic number,
even if the mimetype is correct.

Related issue:#14977

What is the new behavior?

  • Adds afallbackToMimetype option toFileTypeValidator
  • If magic number detection fails, and fallback is enabled, the validator uses the mimetype
  • Also improvesbuildErrorMessage() for clearer failure messages

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

This PR backports the fix originally merged in#14995 into the10.4.17 line.

This was originally reported in#14977. All tests have been verified on the v10 codebase.

@mehdirayan
Copy link

Hi
i have an old code that no longer works after the upgrade.
i intercept the file like this:

@UseInterceptors(
FileInterceptor('photo', { dest: join(__dirname, '..', '/uploads') }),
)
@post()
async uploadeFile(
@uploadedfile(
new ParseFilePipe({
validators: [
new FileTypeValidator({ fileType: 'image/jpeg' }),
new MaxFileSizeValidator({ maxSize: 1024 * 100 }),
],
}),
)
file: Express.Multer.File,
)

The file is saved in the upload folder, so the buffer is missing in the file that is transmitted to validation.
The validation throw a type mismatch exception, with is confusing.

@mag123c
Copy link
ContributorAuthor

@mehdirayan The issue for verifying the magic-number, the root cause of the issue, has not yet been resolved.

Check the issues below#14876,#14977,#15055

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mag123c@mehdirayan
[8]ページ先頭
©2009-2025 Movatter.jp