Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.1k
refactor(common): Switch TypeScriptmodule tonode16#14976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
Borewit wants to merge1 commit intonestjs:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+10 −25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
12 tasks
1a88ce2 to7eed6f0CompareMember
kamilmysliwiec commentedApr 17, 2025
|
83b01ee to8f1537bCompareb429908 toa8ca949Comparefix(deps): update dependency fastify to v5.3.1
a8ca949 to159dfa5CompareContributorAuthor
Borewit commentedApr 18, 2025
@kamilmysliwiec you mind have look at remaining failing unit tests? The FileTypeValidator does not seem to recognize any file running in CircleCI. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch Node.js compiler option
modulefromcommonjstonode16, to preserve dynamic import. Withcommonjsthese are converted torequire. This allows to deprecate theload-esmdependency, introduced in1e43fcb.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Uses
load-esmto be able to load ESM module file-type.Improvement of#14974.
What is the new behavior?
Switches to a more modern version of CommonJS in the TypeScript compiler, which allow dynamic import, which no longer requiresload-esm.
Does this PR introduce a breaking change?
Other information