Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.1k
fix(core): makeisHttpError check stricter#14753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
glebbash wants to merge3 commits intonestjs:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
+53 −2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
coveralls commentedMar 4, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Pull Request Test Coverage Report forBuild 68c3bd7c-e773-48d8-8b6a-74e3bd54e306Details
💛 -Coveralls |
mdovhopo approved these changesMar 4, 2025
Author
glebbash commentedMar 4, 2025
Added |
Author
glebbash commentedMar 5, 2025
@kamilmysliwiec what does the |
Member
kamilmysliwiec commentedMar 5, 2025
@glebbash it means that this PRmay introduce a breaking change. Something to investigate, evaluate risks etc |
Hardanish-Singh approved these changesMay 23, 2025
Hardanish-Singh approved these changesAug 4, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number:#14738
What is the new behavior?
The new logic is stricter and almost the same as the one in
http-errorslibrary.Additional check for
exposeproperty for example should remove a lot of false positives likeResponseErrorfrom ElasticSearch SDK.Does this PR introduce a breaking change?
Not sure