NotificationsYou must be signed in to change notification settings
Fork8.1k
Star74k

Commitf102a01

evgeniy.chernomortsev

committed

fix(common): improve error handling in FileTypeValidator

Add warning logs when file-type package fails to load due to ESMimport issues. This helps users debug issues when running testswith Jest without --experimental-vm-modules flag.When loading fails and fallbackToMimetype is enabled, the validatornow correctly falls back to mimetype comparison instead of silentlyreturning false.Closes#15055

1 parent879d370 commitf102a01Copy full SHA for f102a01

File tree

1 file changed

+24

-1

lines changed

packages/common/pipes/file
- file-type.validator.ts

1 file changed

+24

-1

lines changed

`‎packages/common/pipes/file/file-type.validator.ts‎`

Lines changed: 24 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,10 @@`
	`1`	`+import{Logger}from'../../services/logger.service';`
`1`	`2`	`import{FileValidator}from'./file-validator.interface';`
`2`	`3`	`import{IFile}from'./interfaces';`
`3`	`4`	`import{loadEsm}from'load-esm';`
`4`	`5`
	`6`	`+constlogger=newLogger('FileTypeValidator');`
	`7`	`+`
`5`	`8`	`exporttypeFileTypeValidatorOptions={`
`6`	`9`	`fileType:string\|RegExp;`
`7`	`10`
`@@ -103,7 +106,27 @@ export class FileTypeValidator extends FileValidator<`
`103`	`106`	`return!!file.mimetype.match(this.validationOptions.fileType);`
`104`	`107`	`}`
`105`	`108`	`returnfalse;`
`106`		`-}catch{`
	`109`	`+}catch(error){`
	`110`	`+consterrorMessage=`
	`111`	`+errorinstanceofError ?error.message :String(error);`
	`112`	`+`
	`113`	`+// Check for common ESM loading issues`
	`114`	`+if(`
	`115`	`+errorMessage.includes('ERR_VM_DYNAMIC_IMPORT_CALLBACK_MISSING')\|\|`
	`116`	`+errorMessage.includes('Cannot find module')\|\|`
	`117`	`+errorMessage.includes('ERR_MODULE_NOT_FOUND')`
	`118`	`+){`
	`119`	`+logger.warn(`
	`120`	+`Failed to load "file-type" package for magic number validation. `+
	`121`	+`If using Jest, run with NODE_OPTIONS="--experimental-vm-modules". `+
	`122`	+`Error:${errorMessage}`,
	`123`	`+);`
	`124`	`+}`
	`125`	`+`
	`126`	`+// Fallback to mimetype if enabled`
	`127`	`+if(this.validationOptions.fallbackToMimetype){`
	`128`	`+return!!file.mimetype.match(this.validationOptions.fileType);`
	`129`	`+}`
`107`	`130`	`returnfalse;`
`108`	`131`	`}`
`109`	`132`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commitf102a01

File tree

1 file changed

1 file changed

`‎packages/common/pipes/file/file-type.validator.ts‎`

0 commit comments