Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add ...children rest parameter to unstable_createElement#2761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
faceyspacey wants to merge1 commit intonecolas:master
base:master
Choose a base branch
Loading
fromfaceyspacey:patch-5

Conversation

@faceyspacey
Copy link

@faceyspaceyfaceyspacey commentedFeb 14, 2025
edited
Loading

MirrorReact.createElement(component, props, ...children) as close as possible without breaking current implementation ofunstable_createElement.

This provides a way forward for passing children via the rest parameter, which allows a variable number of a children without warning about missingkey props as occurs withprops.children.

Mirror `React.createElement(component, props, ...children)` as close as possible without breaking current implementation of unstable_createElement
@codesandbox-ci
Copy link

This pull request is automatically built and testable inCodeSandbox.

To see build info of the built libraries, clickhere or the icon next to each commit SHA.

Latest deployment of this branch, based on commit8604be8:

SandboxSource
react-native-web-examplesConfiguration

@quantizor
Copy link

I decided to fork this repo to apply the patch and make it available:https://www.npmjs.com/package/react-native-web-fork

The easiest way to use it is probably this package.json override:

{  "overrides": {    "react-native-web": "npm:react-native-web-fork"  }}

There are other patches applied as well, noted in the package README up top.

faceyspacey reacted with thumbs up emoji

@faceyspacey
Copy link
Author

Sick. You know what you really want for your fork: the layout animation API working. People made progress on it in the past.

https://developer.mozilla.org/en-US/docs/Web/API/ResizeObserver

https://youtu.be/5N_VKQO-oFs?si=T5tMxTj4d8zbBFTk

https://www.youtube.com/live/S6fHb5ChG0A?si=HS-fT5eyH89pKIj0
56 minutes

Check apple's SwiftUI site for how they do animations. Basically the RN layout animation api is that. And recently Android RN finally started supporting it better. It would be really dope to get this working and then write a custom animation library on top of it to ease many common things.

https://developer.apple.com/tutorials/swiftui/animating-views-and-transitions

Their withAnimation API is RN's Layout Animation API.

quantizor reacted with rocket emoji

@quantizor
Copy link

Sick. You know what you really want for your fork: the layout animation API working. People made progress on it in the past.

https://developer.mozilla.org/en-US/docs/Web/API/ResizeObserver

https://youtu.be/5N_VKQO-oFs?si=T5tMxTj4d8zbBFTk

https://www.youtube.com/live/S6fHb5ChG0A?si=HS-fT5eyH89pKIj0 56 minutes

Check apple's SwiftUI site for how they do animations. Basically the RN layout animation api is that. And recently Android RN finally started supporting it better. It would be really dope to get this working and then write a custom animation library on top of it to ease many common things.

https://developer.apple.com/tutorials/swiftui/animating-views-and-transitions

Their withAnimation API is RN's Layout Animation API.

Send me a PR!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@faceyspacey@quantizor

[8]ページ先頭

©2009-2025 Movatter.jp