Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Return box shadow declaration#1525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
sshcrack wants to merge1 commit intonativewind:main
base:main
Choose a base branch
Loading
fromsshcrack:main

Conversation

@sshcrack
Copy link

Currently, the code is missing a return statement in the switch case ofparseDeclaration which is causing the build to crash (on Android) when building and using a box-shadow class. Because of the missing return statement, the box-shadow is parsed as an aspect-ratio, which is causing the crash.

This simple PR should fix this bug.

@deansimcox
Copy link

Nice catch
When I first looked at the rest of the code in this file, I thought there were other cases that weren't returning, but I can see that the return happens after multipleaddStyleProp()'s

@deansimcox
Copy link

This looks to be the same as#1469

@sshcrack
Copy link
Author

Hi, is this PR still relevant? I can't find the parseDeclaration.ts file anywhere? Can this PR be closed?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sshcrack@deansimcox

[8]ページ先頭

©2009-2025 Movatter.jp