NotificationsYou must be signed in to change notification settings
Fork370
Star7.2k

fix: make`getCSSForPlatform` optional#1371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

florian-lefebvre wants to merge1 commit intonativewind:main

base:main

Choose a base branch

fromflorian-lefebvre:florian-lefebvre-patch-1

Open

fix: make`getCSSForPlatform` optional#1371

florian-lefebvre wants to merge1 commit intonativewind:mainfromflorian-lefebvre:florian-lefebvre-patch-1

Conversation

Copy link

florian-lefebvre commentedJan 5, 2025•
edited
Loading

TheWithCssInteropOptions type has 2 required properties:input andgetCSSForPlatform. However when usingwithNativeWind, onlyinput is required at runtime. This PR makes all properties ofWithCssInteropOptions optional when used as thewithNativeWind options.input will be still required since it's overriden

//@ts-check// BEFOREmodule.exports=withNativeWind(config,{input:"./src/global.css",//@ts-expect-error this is overriden, see #1371getCSSForPlatform:undefined});// AFTERmodule.exports=withNativeWind(config,{input:"./src/global.css",});