Commit0fdf81d

authored and

committed

refactor: more robust checking of boolean values (re#171) (#260)

1 parent33b82b6 commit0fdf81dCopy full SHA for 0fdf81d

File tree

-2

lines changed

platform/nativescript
- renderer
  - ViewNode.js
- runtime/modules
  - transition.js

-2

lines changed

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -3,6 +3,7 @@ import set from 'set-value'`
`3`	`3`	`import{getViewMeta,normalizeElementName}from'../element-registry'`
`4`	`4`	`import*asviewUtilfrom'./utils'`
`5`	`5`	`import{isAndroid,isIOS}from'tns-core-modules/platform'`
	`6`	`+import*astypesfrom'tns-core-modules/utils/types'`
`6`	`7`
`7`	`8`	`constXML_ATTRIBUTES=Object.freeze([`
`8`	`9`	`'style',`
`@@ -99,7 +100,7 @@ export default class ViewNode {`
`99`	`100`	`}else{`
`100`	`101`	`// detect expandable attrs for boolean values`
`101`	`102`	`// See https://vuejs.org/v2/guide/components-props.html#Passing-a-Boolean`
`102`		`-if(typeofthis.nativeView[key]==='boolean'&&value===''){`
	`103`	`+if(types.isBoolean(this.nativeView[key])&&value===''){`
`103`	`104`	`value=true`
`104`	`105`	`}`
`105`	`106`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -76,7 +76,9 @@ export function enter(vnode, toggleDisplay) {`
`76`	`76`
`77`	`77`	`constbeforeEnterHook=isAppear ?beforeAppear\|\|beforeEnter :beforeEnter`
`78`	`78`	`constenterHook=isAppear`
`79`		`- ?typeofappear==='function' ?appear :enter`
	`79`	`+ ?typeofappear==='function'`
	`80`	`+ ?appear`
	`81`	`+ :enter`
`80`	`82`	`:enter`
`81`	`83`	`constafterEnterHook=isAppear ?afterAppear\|\|afterEnter :afterEnter`
`82`	`84`	`constenterCancelledHook=isAppear`

Comments

(0)