- Notifications
You must be signed in to change notification settings - Fork88
Move EF Core configurations to feature folders for better vertical slice architecture#16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
Copilot wants to merge3 commits intomainChoose a base branch fromcopilot/fix-b82a5844-5fbb-420b-b588-d4a567700ba6
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
…ice architectureCo-authored-by: nadirbad <33620914+nadirbad@users.noreply.github.com>
Co-authored-by: nadirbad <33620914+nadirbad@users.noreply.github.com>
CopilotAI changed the title[WIP] Why did you choose to seperate the Infra - Configurations?Move EF Core configurations to feature folders for better vertical slice architectureOct 2, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Problem
The
IEntityTypeConfigurationfiles were placed in/Infrastructure/Persistence/Configurations/instead of being co-located with their related features in theFeatures/directory. This violated the vertical slice architecture principle of keeping all related code together by feature rather than separating by technical concerns.Solution
Moved the Entity Framework Core configuration files to their respective feature folders:
TodoItemConfiguration.cs→Features/TodoItems/TodoItemConfiguration.csTodoListConfiguration.cs→Features/TodoLists/TodoListConfiguration.csUpdated the namespaces to match their new feature-specific locations and removed the now-empty
/Configurations/directory.Why This Improves the Architecture
Before: Developers working on TodoItem features had to navigate between
/Features/TodoItems/for business logic and/Infrastructure/Persistence/Configurations/for database configuration.After: All TodoItem-related code (controllers, commands, handlers, validators, domain events, and EF configuration) now lives together in
Features/TodoItems/.This change aligns with the project's stated goal from the README:
Technical Verification
ApplyConfigurationsFromAssembly()automatically discovers configurations regardless of their location in the assemblyThe move demonstrates that infrastructure concerns can and should be organized by feature when they are feature-specific, rather than being artificially separated into technical layers.
Original prompt
✨ Let Copilot coding agentset things up for you — coding agent works faster and does higher quality work when set up for your repo.