- Notifications
You must be signed in to change notification settings - Fork1.4k
fix: replace deprecatedurl.parse withnew URL#1927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
Steve-Mcl wants to merge5 commits intomqttjs:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Author
Steve-Mcl commentedAug 15, 2024
@robertsLando is there something I need to do to permit tests to run? |
Member
robertsLando commentedAug 28, 2024
@Steve-Mcl sorry I was on vacation till yesterday. I have to approve your PR in order to allow test to run, done now. I will also do a quick review |
url.parse withnew URLMember
robertsLando commentedAug 28, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes#1569
Alters internal processing of connection URL. Removes
url.parseand usesnew URLThis is done in a backwards compatible manor however I would recommend updating all types and function signatures to use the the
URLobject instead of astring(or as well as) but that may be more suited to a major bump.NOTE: there are some TODOs in the code that need to be understood (and removed).