Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

AndroidManifest: signal support for SEND and SEND_MULTIPLE intent#1148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
puchu wants to merge1 commit intompv-android:master
base:master
Choose a base branch
Loading
frompuchu:master

Conversation

@puchu
Copy link

@puchupuchu commentedOct 12, 2025•
edited
Loading

AndroidManifest: signal support for SEND and SEND_MULTIPLE intent for audio and video files and implement handling

this intent adds support for example to share videos from the gallery and select mpv-android as the destination

dexaltat reacted with thumbs up emoji
@sfan5
Copy link
Member

Can we start with only the implementation forandroid.intent.action.SEND?
I'm not sure what is the best way to go about handling multiple files. Maybe an in-memory playlist would be cleaner.
similar to this:
https://github.com/mpv-player/mpv/blob/ad59ff1b4a7479e15cb01a96f64ada4fb4df4951/player/lua/ytdl_hook.lua#L1169

@puchupuchuforce-pushed themaster branch 3 times, most recently from7401505 to806335aCompareOctober 14, 2025 21:16
@puchu
Copy link
Author

puchu commentedOct 14, 2025•
edited
Loading

changed the code to use memory:// playlist and added support to share files while the player is already active

@puchupuchuforce-pushed themaster branch 5 times, most recently from201e065 toe94ec1dCompareOctober 15, 2025 02:37
if (filePath!=null) {
MPVLib.command(arrayOf("loadfile", filePathasString))
val path= filePath!!
val method=if (path.startsWith("memory://"))"loadlist"else"loadfile"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

this should work fine withloadfile AFAIK

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

doesn't work with loadfile; loadlist is needed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

why not? I tested this on my desktop mpv and it seemed to work

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

i changed the code to

         if (filePath != null) {             val path = filePath!!-            val method = if (path.startsWith("memory://")) "loadlist" else "loadfile"+            val method = if (path.startsWith("memory://")) "loadfile" else "loadfile"             MPVLib.command(arrayOf(method, path, "replace"))

and compiled it.

when i send multiple files to mpv, it just exits instantly (loadfile only works when i send only one file), using the unmodified (PR) code works as expected.

@puchupuchuforce-pushed themaster branch 3 times, most recently fromfa0465b to164deefCompareOctober 26, 2025 00:57
@puchu
Copy link
Author

what's status? any changes needed to get this merged?

@sfan5
Copy link
Member

I still wanted to to test whyloadfile with a playlist wasn't working (because I'm convinced it should).

@sfan5sfan5 self-requested a reviewNovember 8, 2025 12:33
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@sfan5sfan5Awaiting requested review from sfan5

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@puchu@sfan5
[8]ページ先頭
©2009-2025 Movatter.jp