Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Port Main Screen To M3#1045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
khaled-0 wants to merge11 commits intompv-android:master
base:master
Choose a base branch
Loading
fromkhaled-0:material-home

Conversation

@khaled-0
Copy link
Contributor

This will be porting everything else except for Player

Middlepepper reacted with hooray emojiTerminallyDied and Middlepepper reacted with heart emoji
@sfan5sfan5 self-requested a reviewDecember 7, 2024 14:33
@khaled-0
Copy link
ContributorAuthor

khaled-0 commentedDec 7, 2024
edited
Loading

image

@khaled-0
Copy link
ContributorAuthor

@Marco-9456 look

@khaled-0khaled-0 marked this pull request as ready for reviewDecember 8, 2024 10:23
@khaled-0
Copy link
ContributorAuthor

the legacy file picker is really legacy
it barely works on newer api

@sfan5 should I push a MediaStore based impl in this pr?

@khaled-0
Copy link
ContributorAuthor

Fuckit im doing MediaStore. the legacy fp sucks ass

@khaled-0
Copy link
ContributorAuthor

mediastore ano nee
image

Marco-9456 and dexaltat reacted with heart emoji

@Marco-9456
Copy link

@khaled-0
Well done!

khaled-0 reacted with heart emoji

@khaled-0
Copy link
ContributorAuthor

I have no idea about how I should implement the filepicker. So I'll stop here now with my initial mediastore implementation
image
while I have some idea about what I should implement, I have no inspirations / code to follow here for inspiration. So I'm waiting for some expert suggestions

@Marco-9456
Copy link

@khaled-0 check the Figma file

@sfan5
Copy link
Member

sfan5 commentedJan 13, 2025
edited
Loading

@sfan5 should I push a MediaStore based impl in this pr?

If it's superior the "open document dir" thing could be replaced with MediaStore, but I'd prefer if this PR is design changes only (if possible).
I know the old file picker stuff is terrible. If there's no other way we could leave it as legacy Material for now.

Also, please rebase/conflict resolve this PR.

khaled-0 reacted with eyes emoji

@sfan5
Copy link
Member

@khaled-0 could you rebase this if you have time? I plan to review it next.

@khaled-0
Copy link
ContributorAuthor

@khaled-0 could you rebase this if you have time? I plan to review it next.

yeah I finally got some time, and planning to complete the player (only menu left)
will rebase this too hopefully
in a day or two

sfan5, dexaltat, and Marco-9456 reacted with thumbs up emoji

Unable to Instantiate fragment (Could not find fragment constructor)
@khaled-0
Copy link
ContributorAuthor

It reset the commit history but oh well, rebased

dexaltat reacted with heart emoji

@dexaltat
Copy link

InShot_20250213_234704521.mp4

This probably needs to be fixed. It appears after on/off Material you toggle in General settings.

@SonaliBendre
Copy link

please merge!

@sfan5sfan5 requested review fromsfan5 and removed request forsfan5July 1, 2025 21:05
@dexaltat
Copy link

@sfan5 Sorry to bother you, but could you clarify the situation with the PR regarding the redesign? Everything has been at a standstill for a long time. Is a merge planned?

@sfan5
Copy link
Member

I still plan to look at the redesign PRs by@khaled-0 and incorporate them.

dexaltat and Middlepepper reacted with heart emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@sfan5sfan5Awaiting requested review from sfan5

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@khaled-0@Marco-9456@sfan5@dexaltat@SonaliBendre

[8]ページ先頭

©2009-2025 Movatter.jp