- Notifications
You must be signed in to change notification settings - Fork30
Initial design for Build A/B testing epic story#114
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Perhaps this design of the workflow / task mappings is a reasonable introduction to...more design, thinking and maybe implementing :)
step 3. Run B test
Thank you for working on this! Let me know if it is ready for a review / initial review. Can you take a look at recent changes on the master?@mstachniuk works on e2e testing that overlaps to some degree with A/B comparison. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Good direction! Thanks
| public void apply(final Project project) { | ||
| //Step 1. Clone the repo for A/B testing | ||
| CloneGitHubRepositoryTask clone = project.getTasks().create("cloneGitHubRepository", CloneGitHubRepositoryTask.class); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You can reuseCloneGitRepositoryTask from master now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
k, thx. I will make use of it.
| clone.setTargetDir(new File(project.getBuildDir(), "abTesting/mockito/pristine")); | ||
| //Step 2. Run A test | ||
| RunTestTask runA = project.getTasks().create("runA", RunTestTask.class); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You can reuseRunTestReleaseTask
fix RunTestTask sourceDiradd check if sourceDir (RunTestTask) exists
added some testsfixed bug found by tests
added testsfixed serialization
…iling previously due to missing md5 check
@szczepiq I'd kindly ask you for a initial review.Analyze comparison results is still missing, but other than that everything should be in place. |
Hey@epeee, I missed your earlier question, will do review as soon as I can. |
I wanted to work on this today but I deprioritized this ticket again. Will try to find time for this soon. If I cannot make the time, we'll have to push it to after 1.0. Sorry and thanks for patience! |
Hey@epeee, let's deprioritize this ticket for now and revisit when e2e testing is complete after 1.0. I'm finding it hard to focus on this at the moment. In the meantime, I've added 2 more "please contribute" tickets that would be really useful for 1.0 release! |
Suggested starting point design / implementation for#113
It's only a suggestion!!!