Commit8d02a82

Sergio García Prado

committed

* Fix bug related with non-hashable `Entity` instances within `EntitySet`.

1 parent66e60ed commit8d02a82Copy full SHA for 8d02a82

File tree

+10

-1

lines changed

packages/core/minos-microservice-aggregate
- minos/aggregate/entities
  - collections.py
- tests/test_aggregate/test_entities
  - test_collections.py

+10

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -141,7 +141,7 @@ def decode_data(cls, decoder: DataDecoder, target: Any, type_: ModelType, **kwar`
`141`	`141`	`:return: A decoded instance.`
`142`	`142`	`"""`
`143`	`143`	`data_cls=get_args(type_.type_hints["data"])[1]`
`144`		`-target={decoder.build(v,data_cls,**kwargs)forvintarget}`
	`144`	`+target=(decoder.build(v,data_cls,**kwargs)forvintarget)`
`145`	`145`	`target= {str(v["uuid"]):vforvintarget}`
`146`	`146`	`decoded=decoder.build(target,type_.type_hints["data"],**kwargs)`
`147`	`147`	`returncls(decoded,additional_type_hints=type_.type_hints)`

Lines changed: 9 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -8,6 +8,7 @@`
`8`	`8`
`9`	`9`	`fromminos.aggregateimport (`
`10`	`10`	`Action,`
	`11`	`+Entity,`
`11`	`12`	`EntitySet,`
`12`	`13`	`IncrementalSetDiff,`
`13`	`14`	`IncrementalSetDiffEntry,`
`@@ -20,6 +21,10 @@`
`20`	`21`	`)`
`21`	`22`
`22`	`23`
	`24`	`+class_NotHashable(Entity):`
	`25`	`+foo:set[int]`
	`26`	`+`
	`27`	`+`
`23`	`28`	`classTestEntitySet(unittest.TestCase):`
`24`	`29`	`deftest_data(self):`
`25`	`30`	`raw= {OrderItem("John"),OrderItem("Michael")}`
`@@ -139,6 +144,10 @@ def test_avro_bytes(self):`
`139`	`144`	`expected=EntitySet({OrderItem("John"),OrderItem("Michael")})`
`140`	`145`	`self.assertEqual(expected,Model.from_avro_bytes(expected.avro_bytes))`
`141`	`146`
	`147`	`+deftest_avro_bytes_not_hashable(self):`
	`148`	`+expected=EntitySet([_NotHashable({1}),_NotHashable({2})])`
	`149`	`+self.assertEqual(expected,Model.from_avro_bytes(expected.avro_bytes))`
	`150`	`+`
`142`	`151`
`143`	`152`	`classTestEntitySetDiff(unittest.TestCase):`
`144`	`153`	`defsetUp(self)->None:`

Comments

(0)