Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Normalizing asserts to fluent-styleexpect#20490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
Benjin wants to merge2 commits intomain
base:main
Choose a base branch
Loading
fromdev/benjin/normalizeAsserts

Conversation

@Benjin
Copy link
Contributor

@BenjinBenjin commentedNov 7, 2025•
edited
Loading

Pull Request Template – vscode-mssql

Description

Moving all remaining asserts to fluent-styleexpect(x).to.be(y) where possible.

TODO:

  • add warning rule when attempting to importassert library

Code Changes Checklist

  • New or updatedunit tests added
  • All existing tests pass (npm run test)
  • Code followscontributing guidelines
  • Telemetry/logging updated if relevant
  • No regressions or UX breakage

Reviewers:Please read our reviewer guidelines

@github-actions
Copy link

github-actionsbot commentedNov 7, 2025•
edited
Loading

PR Changes

CategoryTarget BranchPR BranchDifference
Code Coverage58.83%58.83%⚪ 0.00%
VSIX Size5209 KB5209 KB⚪ 0 KB ( 0% )
Webview Bundle Size5216 KB5216 KB⚪ 0 KB ( 0% )

@codecov-commenter
Copy link

codecov-commenter commentedNov 7, 2025•
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.76%. Comparing base (0932470) to head (096e999).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@##             main   #20490   +/-   ##=======================================  Coverage   56.76%   56.76%           =======================================  Files         205      205             Lines       18369    18369             Branches     1164     1164           =======================================  Hits        10428    10428             Misses       7941     7941
🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@kburtramkburtramAwaiting requested review from kburtramkburtram will be requested when the pull request is marked ready for reviewkburtram is a code owner

@aasimkhan30aasimkhan30Awaiting requested review from aasimkhan30aasimkhan30 will be requested when the pull request is marked ready for reviewaasimkhan30 is a code owner

@caohaicaohaiAwaiting requested review from caohaicaohai will be requested when the pull request is marked ready for reviewcaohai is a code owner

@laurenastrid1laurenastrid1Awaiting requested review from laurenastrid1laurenastrid1 will be requested when the pull request is marked ready for reviewlaurenastrid1 is a code owner

@lewis-sanchezlewis-sanchezAwaiting requested review from lewis-sanchezlewis-sanchez will be requested when the pull request is marked ready for reviewlewis-sanchez is a code owner

@allancascanteallancascanteAwaiting requested review from allancascanteallancascante will be requested when the pull request is marked ready for reviewallancascante is a code owner

@ssreeramassreeramaAwaiting requested review from ssreeramassreerama will be requested when the pull request is marked ready for reviewssreerama is a code owner

@manujoseph85manujoseph85Awaiting requested review from manujoseph85manujoseph85 will be requested when the pull request is marked ready for reviewmanujoseph85 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Benjin@codecov-commenter
[8]ページ先頭
©2009-2025 Movatter.jp