Commitb8f35f4

authored

U/jarmit/fix mutator name (#141)

* Setting the name of the mutator instead of the name of the creating function* 4.2.2* fix tests* Actually fix tests* rename

1 parente964670 commitb8f35f4Copy full SHA for b8f35f4

File tree

-5

lines changed

-5

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name":"satcheljs",`
`3`		`-"version":"4.2.1",`
	`3`	`+"version":"4.2.2",`
`4`	`4`	`"description":"Store implementation for functional reactive flux.",`
`5`	`5`	`"lint-staged": {`
`6`	`6`	`"*.{ts,tsx}": [`

Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -17,9 +17,10 @@ export default function mutator<TAction extends ActionMessage, TReturn>(`
`17`	`17`	`}`
`18`	`18`
`19`	`19`	`// Wrap the callback in a MobX action so it can modify the store`
`20`		`-letwrappedTarget=action(getPrivateActionType(actionCreator),(actionMessage:TAction)=>{`
	`20`	`+constactionType=getPrivateActionType(actionCreator);`
	`21`	`+letwrappedTarget=action(actionType,(actionMessage:TAction)=>{`
`21`	`22`	`try{`
`22`		`-getGlobalContext().currentMutator=actionCreator.name;`
	`23`	`+getGlobalContext().currentMutator=actionType;`
`23`	`24`	`target(actionMessage);`
`24`	`25`	`}finally{`
`25`	`26`	`getGlobalContext().currentMutator=null;`

Lines changed: 5 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -64,9 +64,12 @@ describe('mutator', () => {`
`64`	`64`
`65`	`65`	`it('sets the currentMutator to actionMessage type for the duration of the mutator callback',()=>{`
`66`	`66`	`// Arrange`
`67`		`-letactionCreator:any={__SATCHELJS_ACTION_ID:'testAction',name:'testName'};`
	`67`	`+letactionCreator:any={`
	`68`	`+__SATCHELJS_ACTION_ID:'testAction',`
	`69`	`+__SATCHELJS_ACTION_TYPE:'testActionType',`
	`70`	`+};`
`68`	`71`	`letcallback=()=>{`
`69`		`-expect(mockGlobalContext.currentMutator).toBe('testName');`
	`72`	`+expect(mockGlobalContext.currentMutator).toBe('testActionType');`
`70`	`73`	`};`
`71`	`74`	`mutator(actionCreator,callback);`
`72`	`75`

Comments

(0)