Commit155b35d

authored

Cleanup redundant stack frames (#125)

Drawing on the learnings from#124, this removes some unnecessary anonymous functions from the modern Satchel dispatch pipeline.

1 parentd76863e commit155b35dCopy full SHA for 155b35d

File tree

-7

lines changed

-7

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -13,5 +13,5 @@ export default function applyMiddleware(...middleware: Middleware[]) {`
`13`	`13`	`}`
`14`	`14`
`15`	`15`	`functionapplyNextMiddleware(middleware:Middleware,next:DispatchFunction):DispatchFunction{`
`16`		`-returnactionMessage=>middleware(next,actionMessage);`
	`16`	`+returnmiddleware.bind(null,next);`
`17`	`17`	`}`

Lines changed: 3 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -19,10 +19,7 @@ export function dispatch(actionMessage: ActionMessage) {`
`19`	`19`	`}`
`20`	`20`
`21`	`21`	`letdispatchWithMiddleware=getGlobalContext().dispatchWithMiddleware\|\|finalDispatch;`
`22`		`-`
`23`		`-transaction(()=>{`
`24`		`-dispatchWithMiddleware(actionMessage);`
`25`		`-});`
	`22`	`+transaction(dispatchWithMiddleware.bind(null,actionMessage));`
`26`	`23`	`}`
`27`	`24`
`28`	`25`	`exportfunctionfinalDispatch(actionMessage:ActionMessage):void\|Promise<void>{`
`@@ -32,12 +29,12 @@ export function finalDispatch(actionMessage: ActionMessage): void \| Promise<void`
`32`	`29`	`if(subscribers){`
`33`	`30`	`letpromises:Promise<any>[]=[];`
`34`	`31`
`35`		`-subscribers.forEach(subscriber=>{`
	`32`	`+for(constsubscriberofsubscribers){`
`36`	`33`	`letreturnValue=subscriber(actionMessage);`
`37`	`34`	`if(returnValue){`
`38`	`35`	`promises.push(returnValue);`
`39`	`36`	`}`
`40`		`-});`
	`37`	`+}`
`41`	`38`
`42`	`39`	`if(promises.length){`
`43`	`40`	`returnpromises.length==1 ?promises[0] :Promise.all(promises);`

Comments

(0)