Commitd2c6478

authored

Simplify the empty epic to actually do nothing

The current `emptyEpic` could create an infinite loop if an end user actually dispatched an element of type `noop`. Using `ignoreElements` instead will just sink all actions.

1 parent163377f commitd2c6478Copy full SHA for d2c6478

File tree

1 file changed

-3

lines changed

packages/redux-dynamic-modules-observable/src
- EpicManager.ts

1 file changed

-3

lines changed

`‎packages/redux-dynamic-modules-observable/src/EpicManager.ts‎`

Lines changed: 2 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`import{getObjectRefCounter,IItemManager}from"redux-dynamic-modules-core";`
`2`	`2`	`import{Epic,ofType,EpicMiddleware}from"redux-observable";`
`3`	`3`	`import{Observable,Subject}from"rxjs";`
`4`		`-import{mapTo,switchMap}from"rxjs/operators";`
	`4`	`+import{ignoreElements,switchMap}from"rxjs/operators";`
`5`	`5`
`6`	`6`	`exportinterfaceIEpicManagerextendsIItemManager<Epic>{`
`7`	`7`	`// some extra properties`
`@@ -121,7 +121,6 @@ function createReplaceableWrapper() {`
`121`	`121`	`*/`
`122`	`122`	`functionemptyEpic(action$){`
`123`	`123`	`returnaction$.pipe(`
`124`		`-ofType("noop"),`
`125`		`-mapTo({type:"noop"})`
	`124`	`+ignoreElements()`
`126`	`125`	`);`
`127`	`126`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitd2c6478

File tree

1 file changed

1 file changed

`‎packages/redux-dynamic-modules-observable/src/EpicManager.ts‎`

0 commit comments